summaryrefslogtreecommitdiff
path: root/test/MultiDexModifiedSecondary/Main.java
diff options
context:
space:
mode:
authorAlex Light <allight@google.com>2020-11-30 16:58:05 -0800
committerTreehugger Robot <treehugger-gerrit@google.com>2020-12-01 20:12:45 +0000
commit210a78d9ec4349601ac57381046229f4da1197f4 (patch)
treedba581ba26ba7f6add0c3c1a2968d4f5d5dc8336 /test/MultiDexModifiedSecondary/Main.java
parent59d4b53e70bc1e0589ce05428c945b4585e28d0f (diff)
Ensure ClearLoopInformation doesn't require particular ordering
The ClearLoopInformation call used to use the RPO list to find blocks which potentially had loop-information. This meant that if one was also clearing the dominance information (which is quite common) one needed to be sure to call ClearLoopInformation before calling ClearDominanceInformation or else loop information will not be fully cleared. This could cause quite perplexing errors if dominance information is recomputed later (also quite common). This error is in fact present in several tests (none of which use loops which is how it got missed). Fix this issue by just looping over all blocks. Also add a new GetActiveBlocks function which does the filtering of null blocks automatically. In many cases (such as these) we use RPO purely because it doesn't require filtering. This should be able to replace these uses. Test: ./test.py --host Change-Id: I60c7defc409111471064e9bf02b7ae3a0eb10584
Diffstat (limited to 'test/MultiDexModifiedSecondary/Main.java')
0 files changed, 0 insertions, 0 deletions